[vlc-devel] [vlc-commits] commit: Linking to X11 is optional (Christophe Mutricy )

[Rémi Denis-Courmont]

----- Message d'origine -----
> vlc | branch: master | Christophe Mutricy <xtophe at videolan.org> | Fri May 21
> 23:33:05 2010 +0100| [d00684982028100b9caee5b9fe03f007b10f8059] | committer:
> Christophe Mutricy
>
> Linking to X11 is optional

Linking to Xlib is MANDATORY if libpulse has Xlib support (which it normally if not always has), and optional but harmless if it does not.

I would not call this "optional" really.

> if you compile without X and then run with an X-enabled
> PulseAudio, boom.

This commit complete crap in my opinion. I find build failures in the packagers face a much much much better failure mode than crashing (pseudo-randomly on top of that) in the user face.

Of course, a nice explanatory error in configure is even better than an obscure build failure.

-- 
Rémi