[vlc-devel] [vlc-commits] commit: Added vout_display_info_t::has_event_thread. (Laurent Aimar )

[Rémi Denis-Courmont]

Le dimanche 30 mai 2010 15:54:54 git at videolan.org, vous avez écrit :
> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Sun May 30
> 14:44:17 2010 +0200| [6c73ecd0995166536973595f63e08ed51f2e54f5] |
> committer: Laurent Aimar
> 
> Added vout_display_info_t::has_event_thread.
> 
> If false, the vout core will use a thread to dispatch key events.
> It reimplement [cb72d26f0825b31fd10af18a03763b41067cfe37] using a bit less
> code and by adding support for multiple keys pressed in a row.
> The thread is created only if needed.

Cluttering the vout core for the sake of misdesigned plugins seems highly 
suboptimal to me. Only you understand it and you're making it needlessly 
complicated now.

Sure, the block_Fifo is simpler and semantically more correct, but that could 
have been done with the previous API too.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis