[vlc-devel] [PATCH] access module for BlackMagic SDI cards

[Rémi Denis-Courmont]

   Hello,

On Saturday 02 October 2010, Steinar H. Gunderson wrote:
> New patch attached.

+    add_string( "decklink-video-connection", 0, NULL,
+                 VIDEO_CONNECTION_TEXT, VIDEO_CONNECTION_LONGTEXT, true )

I guess there should be a predefined list of choices. Look for 
change_integer_list or change_string_list.

+    psz_video_connection = var_CreateGetNonEmptyString( p_demux, "decklink-
video-connection" );

You could use var_InheritString() here. It returns NULL if the value is 
unspecified.

Als a few general questions... I guess this plugin copies entire video frames 
from the SDK into VLC block_t. The rawvideo codec will again copy those entire 
frames into VLC pictures_t. Is this intended?

And does Demux() not get stuck if we never get an image? Is that possible at 
all? Do you really need the mutex and condition variable?

-- 
Rémi Denis-Courmont
http://www.remlab.net/