[vlc-devel] [PATCH] access module for BlackMagic SDI cards

[Jean-Baptiste Kempf]

On Tue, Oct 05, 2010 at 12:46:52PM +0200, Steinar H. Gunderson wrote :
> On Tue, Oct 05, 2010 at 05:17:18PM +1100, Stuart Cunningham wrote:
> >>+    const char *psz_model_name;
> >>+    result = p_sys->p_card->GetModelName( &psz_model_name );
> > This will fail to compile under Mac and Windows, since the DeckLink
> > API uses different string types for those two platforms, namely
> > CFString for Mac and BSTR for Windows.  So use suitable macros to do
> > the platform tests - perhaps a static function like
> > getDeckLinkModelName() returning a const char* could keep the platform
> > differences away from the flow of Open().  Same problem occurs with
> > p_display_mode->GetName().
> 
> Yes. This is already covered in the NEWS file and discussed here. I guess
> porting would be easy for anyone on Windows, though.

And with the right hardware. :D

Anyway, this is perfectly fine to care about open source OSes first and
then other platforms.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734