[vlc-devel] [PATCH 1/4] Base Media Library Module files

Rémi Denis-Courmont remi at remlab.net
Mon Oct 18 21:59:10 CEST 2010

Le dimanche 17 octobre 2010 22:39:21 Srikanth Raju, vous avez écrit :
> Hi All,
> The following 4 patches contain the Media library module files. Please
> review them. ivoire and courmisch have already reviewed them on the last
> mail I've sent and this is just to finalize things.
> I will merge all these into trunk within 7-10 days if no serious problems
> are found.
> Thank you.

* Using var_Create where not useful.
* vlc_thread_create/vlc_thread_join/vlc_object_kill are deprecated.
* I can't even find the thread function. Does this code links at all??
* The big IF_CMP/ELSE_CMP list should be replaced with a static mapping table 
and a binary search. It would also remove the need for the huge switch.

Rémi Denis-Courmont

More information about the vlc-devel mailing list