[vlc-devel] [vlc-commits] commit: broken avi dialog: don't confuse user by asking a binary answer ( Francois Cartegnie )

[xxcv]

On 18/09/2010 6:37 AM, git at videolan.org wrote:
> vlc | branch: master | Francois Cartegnie<fcvlcdev at free.fr>  | Thu Sep 16 15:09:39 2010 +0200| [f42b56bb857128e3551baafb8f8acc34da18c40b] | committer: Francois Cartegnie
>
> broken avi dialog: don't confuse user by asking a binary answer
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f42b56bb857128e3551baafb8f8acc34da18c40b
> ---
>
>   modules/demux/avi/avi.c |   10 +++++-----
>   1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/modules/demux/avi/avi.c b/modules/demux/avi/avi.c
> index cc3f374..1420fec 100644
> --- a/modules/demux/avi/avi.c
> +++ b/modules/demux/avi/avi.c
> @@ -655,11 +655,11 @@ aviindex:
>                   b_index = true;
>                   goto aviindex;
>               }
> -            switch( dialog_Question( p_demux, _("AVI Index") ,
> -               _( "This AVI file is broken. Seeking will not work correctly.\n"
> -                  "Do you want to try to fix it?\n\n"
> -                  "This might take a long time." ),
> -                  _( "Repair" ), _( "Don't repair" ), _( "Cancel") ) )
> +            switch( dialog_Question( p_demux, _("Broken AVI Index") ,
> +               _( "Because this AVI file is broken, seeking will not work correctly.\n"
> +                  "It can be fixed, but this step might take a long time.\n"
> +                  "What do you want to do ?" ),
> +                  _( "Repair and play" ), _( "Play as is" ), _( "Do not play") ) )
IMO,
i think i got more confused because you just said the word 'play' inside 
every single button ... errr. Now im even more confused...
Because some a not very computer / IT literate person can't tell what is 
going on in this question and answer, so why would you bring up such 
complexity ?
e.g, a do not play button shouldn't have the word __play__ in it.
>               {
>                   case 1:
>                       b_index = true;
>


-- 
My VLC, My Way, My Style~

|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination