[vlc-devel] Deinterlacer TODO / updated

[Glen Gray]

On 18 Apr 2011, at 10:39, Juha Jeronen wrote:

> Hi,
> 
> On 04/18/2011 12:22 PM, Jean-Baptiste Kempf wrote:
>> Hello,
>> 
>> On Mon, Apr 18, 2011 at 12:04:23PM +0300, Juha Jeronen wrote :
>>> Now that Phosphor and IVTC are functional and merged, it's time to
>>> update the plan again.
>> Congratz again.
> 
> Thanks :)
> 
> 
>>> 1) Refactor deinterlace.c:
>> Would be more than welcome here.
> 
> One refactor, coming up... I too think that this needs to be done now,
> in order to make it maintainable (and approachable) again. Right now
> it's probably just me and Laurent who know how it works :)
> 
> 
>>>  - Make a subdirectory (in video_filter), move deinterlace.c there
>>>  - Update Modules.am
>> Try to avoid creating another Modules.am in the subfolder, but use the
>> Modules.am that is already existing.
> 
> Ok.
> 
> 
>>>  - Wrap the code to 79 columns or less.
>> I have to say that, for me, this is not really important.
> 
> Ok. But it's not that much work, either (since I'll be going through all
> the code anyway), and it'd be nice for consistency. As it is now, the
> module is *mostly* 79 columns per line. The main offenders are my
> comment about i_frame_offset and some individual lines here and there
> from the old algorithms.
> 
> 
>>> 2) Finish X (2x).
>>>  - Rename to something sensible. Suggestions appreciated :)
>> xXx
> 
> XD
> 
> 
>>> 3) Update the end-user doc, and write a developer doc for the deinterlacer.
>> Don't hesitate to modify the wiki, even if not finished.
> 
> Ok. I might interleave the doc update with the other items, then.


I'm just going to mention something that we noticed recently. I'm not sure if it's already being addressed as part of this work.

With a de-interlace filter active, Subtitles are flashing on and off the screen for all filters except Blend and X.

Kind Regards,
--
Glen Gray
<slaine at slaine.org>