[vlc-devel] [PATCH] For MacOSX to support QTK capture device other than iSight 1/3

Felix Paul Kühne fkuehne.videolan at googlemail.com
Tue Apr 19 18:04:58 CEST 2011


On 19.04.2011, at 15:20, Katsushi Kobayashi <ikob at riken.jp> wrote:

> Hi, 
> This series is a patch for MacOSX to support additional capture device
> in addition to default QTK capture device. I have once submitted the
> same patch. Unfortunately, it was rejected because of my messy code :)
> Also, the series includes some binary data for GUI definition.
First of all, thanks for your contribution.

While I didn't compile your patch yet, so far, it looks fine for me as far as I can say. However, please resend your patches according to the guidelines available on [1], so you retain your copyright on merge. Additionally, please make the newly introduced term "None" localizable by adding the usual _NS wrapper.
Did you test your patches against the stable or the unstable branch of VLC? (should be the latter) and are the used QTKit methods available within the 10.5 SDK?

Best regards,


[1] http://wiki.videolan.org/Sending_Patches_VLC

More information about the vlc-devel mailing list