[vlc-devel] [PATCH] For MacOSX to support QTK capture device other than iSight 1/3

[Katsushi Kobayashi]

Hi,

I just learned the manner how to contribute VLC :)

The patch I sent should be applied to the latest 1.1 branch. I also have another
patch for the master branch that can be successfully compiled. However, I have
never compiled it without the modification as
http://www.mail-archive.com/vlc-commits@videolan.org/msg00299.html

Of course, the modification eliminates vout. So, I could not check whether my
modification is fine or not.

Does anybody know how to build VLC.app using master branch ?

BTW, QTKit capture method has been available from OSX 10.5.

Regards,

----
Katsushi Kobayashi




On 2011/04/20, at 1:04, Felix Paul Kühne wrote:

> Hello,
> 
> On 19.04.2011, at 15:20, Katsushi Kobayashi <ikob at riken.jp> wrote:
> 
>> Hi, 
>> 
>> This series is a patch for MacOSX to support additional capture device
>> in addition to default QTK capture device. I have once submitted the
>> same patch. Unfortunately, it was rejected because of my messy code :)
>> 
>> Also, the series includes some binary data for GUI definition.
> First of all, thanks for your contribution.
> 
> While I didn't compile your patch yet, so far, it looks fine for me as far as I can say. However, please resend your patches according to the guidelines available on [1], so you retain your copyright on merge. Additionally, please make the newly introduced term "None" localizable by adding the usual _NS wrapper.
> Did you test your patches against the stable or the unstable branch of VLC? (should be the latter) and are the used QTKit methods available within the 10.5 SDK?
> 
> Best regards,
> 
> Felix
> 
> [1] http://wiki.videolan.org/Sending_Patches_VLC
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel