[vlc-devel] Hotkeys, action and interfaces?

Jean-Baptiste Kempf jb at videolan.org
Sat Apr 23 17:48:07 CEST 2011

On Sat, Apr 23, 2011 at 05:47:17PM +0300, Rémi Denis-Courmont wrote :
> I guess an interface plugin was more convenient when the hotkeys interface ran 
> a thread of its own. I put the key mapping code in the core; previously, each 
> key handler did the same mapping itself.

> Eventually, key presses should be handled per video output/window, then per 
> input, then per input manager/parent. As such, the hotkeys interface will go 
> away. But until that rework is taken care of, I don't see any value in moving 
> the action handler code to the core. It does not really bring any benefit.

The question was more is it possible to remove some of the code of
qt/macosx that is duplicated in hotkeys/qt/mac, like "faster_fine",
"slower_fine", etc...

> key-pressed (NEVER directly via key-action). Conversely, to perform a specific 
> action, not triggered by a hotkey, Just Do It(tm). Don't use "key-pressed" or 
> "key-action" at all.

Well, yes, but for example, see AdjustRateFine() in
modules/control/hotkeys.c that isn't available in qt/macos without
recoding it completly.
(The 2 actions related to this function are the
only ACTIONID used in Qt, btw... Mac is not as good though...)

Best Regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list