[vlc-devel] [PATCH] Use a private dbus connection in the inhibit and telepathy modules

[mirsal]

On Thu, 2011-08-11 at 12:12 +0200, Rémi Denis-Courmont wrote:
> On Thu, 11 Aug 2011 12:04:16 +0200, Mirsal Ennaime <mirsal at mirsal.fr>
> wrote:
> > libdbus has multiple thread-safety issues and using private connections
> > (ie: not shared with other vlc modules) helps avoiding some of them.
> 
> I don't really see how this fixes any of the real thread-safety issues.

These modules call dbus_connection_send_with_reply_and_block from
different threads, potentially at the same time, which is risky.

> That is probably not possible without changes in libdbus anyway.

I agree, and I am trying to convince the dbus people to at least secure
the use case of each thread using their own private connection.

In the meantime, I am going to push this to master if you don't object.

Best,

-- 
mirsal 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110811/e8a77199/attachment.sig>