[vlc-devel] [PATCH] Use a private dbus connection in the inhibit and telepathy modules

[Rémi Denis-Courmont]

On Thu, 11 Aug 2011 12:24:01 +0200, mirsal <mirsal at mirsal.fr> wrote:
> On Thu, 2011-08-11 at 12:12 +0200, Rémi Denis-Courmont wrote:
>> On Thu, 11 Aug 2011 12:04:16 +0200, Mirsal Ennaime <mirsal at mirsal.fr>
>> wrote:
>> > libdbus has multiple thread-safety issues and using private
connections
>> > (ie: not shared with other vlc modules) helps avoiding some of them.
>> 
>> I don't really see how this fixes any of the real thread-safety issues.
> 
> These modules call dbus_connection_send_with_reply_and_block from
> different threads, potentially at the same time, which is risky.
> 
>> That is probably not possible without changes in libdbus anyway.
> 
> I agree, and I am trying to convince the dbus people to at least secure
> the use case of each thread using their own private connection.

"Since multithreaded libdbus use is relatively rare I'd lean toward
keeping things correct in single-threaded apps, and let threaded apps
adapt"
said D-Bus author (https://bugs.freedesktop.org/show_bug.cgi?id=27585).

This is hopeless. We should rather get rid of libdbus and use better
bindings.
Or actually, we should get rid of the D-Bus protocol altogether because
its design is utter crap.

-- 
Rémi Denis-Courmont
http://www.remlab.net/