[vlc-devel] Factor HTTP/HTTPS/RTSP port in core

[Rémi Denis-Courmont]

Le dimanche 14 août 2011 21:09:24 Pierre Ynard, vous avez écrit :
> What's the rationale behind these changes, besides factorization? This
> breaks existing settings, and takes away granularity. What if I want to
> run a combination of http interface/streams on different
> addresses/ports?

The syntax was very confusing. Sorry but http://:8080/foobar is NOT an URL and 
I have not seen it used _anywhere_ else. But worse, the code to reuse hosts 
never ever worked correctly.

With this approach, everything works just fine. We have one port per protocol, 
easily configurable. We also have one unique TLS configuration, which is the 
only setup that actually ever worked.

And there is absolutely zero point in using multiple ports. This is not RTP. 
You can always define different paths.

>      char *hostname = var_InheritString( p_this->p_libvlc, hostvar );
> -    host->fds = net_ListenTCP( p_this, hostname, i_port );
> +    int port = var_InheritInteger( p_this->p_libvlc, portvar );
> 
> Using p_this->p_libvlc prevents a calling module to set and use its own
> bind address through inheritance. But maybe that's your very intent?

It wouldn't make sense.

Unless someone has a plan on how to fix the old design to not be highly 
confusing, hard to configure and plain buggy, I am not interested in 
discussing this.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis