[vlc-devel] [PATCH] picture_BlendSubpicture() : ensure the chromas are compatible

Rémi Denis-Courmont remi at remlab.net
Fri Dec 2 18:36:29 CET 2011


Le vendredi 2 décembre 2011 18:23:49 Rafaël Carré, vous avez écrit :
> > -    assert(blend && dst && blend->fmt_out.video.i_chroma ==
> > dst->format.i_chroma); +    assert(blend && dst &&
> > +       
> > !memcmp(vlc_fourcc_GetChromaDescription(blend->fmt_out.video.i_chroma),
> > +                vlc_fourcc_GetChromaDescription(dst->format.i_chroma),
> > +                sizeof(vlc_chroma_description_t)));
> > +
> > 
> >      assert(src && !src->b_fade && src->b_absolute);
> >      
> >      for (subpicture_region_t *r = src->p_region; r != NULL; r =
> >      r->p_next) {
> 
> ping (fixes #5516)

It makes sense but it looks ugly as hell :P

> Do we need a i420 <-> j420 filter instead?

I wonder... Laurent?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list