[vlc-devel] [PATCH] picture_BlendSubpicture() : ensure the chromas are compatible

[Laurent Aimar]

On Fri, Dec 02, 2011 at 07:36:29PM +0200, Rémi Denis-Courmont wrote:
> Le vendredi 2 décembre 2011 18:23:49 Rafaël Carré, vous avez écrit :
> > > -    assert(blend && dst && blend->fmt_out.video.i_chroma ==
> > > dst->format.i_chroma); +    assert(blend && dst &&
> > > +       
> > > !memcmp(vlc_fourcc_GetChromaDescription(blend->fmt_out.video.i_chroma),
> > > +                vlc_fourcc_GetChromaDescription(dst->format.i_chroma),
> > > +                sizeof(vlc_chroma_description_t)));
> > > +
> > > 
> > >      assert(src && !src->b_fade && src->b_absolute);
> > >      
> > >      for (subpicture_region_t *r = src->p_region; r != NULL; r =
> > >      r->p_next) {
> > 
> > ping (fixes #5516)
> 
> It makes sense but it looks ugly as hell :P
 yes :(
> 
> > Do we need a i420 <-> j420 filter instead?
 Not really. We could but it's way better done at the vout level.

Anyway, about the assert, I think we could also simply remove it.

-- 
fenrir