[vlc-devel] [PATCH] Make the Mac DMG prettier.

[Felix Paul Kühne]

Hello,

Am 27.12.2011 um 03:39 schrieb Rafaël Carré:

> Le 2011-12-26 21:07, Brendon Justin a écrit :
>> 
[cut]
>>  	rm -f "$(top_builddir)/vlc-$(VERSION)-rw.dmg"
>> -	hdiutil create -verbose -srcfolder "$(top_builddir)/vlc-$(VERSION)" "$(top_builddir)/vlc-$(VERSION)-rw.dmg" -scrub
>> +	hdiutil create -verbose -srcfolder "$(top_builddir)/vlc-$(VERSION)" "$(top_builddir)/vlc-$(VERSION)-rw.dmg" -scrub -format UDRW
>> +	hdiutil attach -readwrite -noverify -noautoopen "vlc-$(VERSION)-rw.dmg"
> 
> I think it'd be better to mount the dmg to a mount point in the current directory instead of /Volumes

I tend to disagree here for the sake of simplicity. The mounted dmg is only present for a few seconds while this script is running, so there is a high chance of not conflicting with anything running on the dev's box.

Additionally, the needed option "-mountroot" (for the attach command) only understands path up to a total length of 90  characters, a limit which was only recently moved to 1024 characters…


There is another problem with Brendon's script which he mentioned in the related trac ticket: it requires the accessibility settings to be enabled on the box creating the dmg to let the AppleScript do the stuff he wants it to do.
At present, this script doesn't check for the enabled accessibility stuff and will utterly fail on Macs with the default configuration.

Except for that, it's a nice contribution :-)

Best regards,

Felix