[vlc-devel] [PATCH] Fix bug in taglib txxx handling

Johannes Weißl jargon at molb.org
Wed Feb 9 14:29:07 CET 2011


On Wed, Feb 09, 2011 at 02:23:25PM +0100, Johannes Weißl wrote:
> This makes ReplayGain work for mp3 files.

This is not true in all cases: foobar2000 writes ReplayGain tags in
lowercase (replaygain_track_gain), which VLC doesn't recognize.

What would be the best way to fix that?
1. Store extra tags all in lowercase / uppercase [vlc_meta_AddExtra()]
2. Get extra tags case insensitive [vlc_meta_GetExtra()]
3. Just get ReplayGain extra tags case insensitive
   [vlc_audio_replay_gain_MergeFromMeta()]

Greetings,
Johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110209/b6a04fbe/attachment.sig>


More information about the vlc-devel mailing list