[vlc-devel] [PATCH] Fix bug in taglib txxx handling

[Jean-Baptiste Kempf]

Hello,

On Wed, Feb 09, 2011 at 02:29:07PM +0100, Johannes Weißl wrote :
> On Wed, Feb 09, 2011 at 02:23:25PM +0100, Johannes Weißl wrote:
> > This makes ReplayGain work for mp3 files.
> 
> This is not true in all cases: foobar2000 writes ReplayGain tags in
> lowercase (replaygain_track_gain), which VLC doesn't recognize.
> 
> What would be the best way to fix that?
> 1. Store extra tags all in lowercase / uppercase [vlc_meta_AddExtra()]

And that will break some tags, no?

> 2. Get extra tags case insensitive [vlc_meta_GetExtra()]

That might break some tags, no?

> 3. Just get ReplayGain extra tags case insensitive
>    [vlc_audio_replay_gain_MergeFromMeta()]
I would do that, yes.

Rémi? opinion?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734