[vlc-devel] [PATCH] Again compilation warnings fixes

Guillaume Poussel gpoussel at gmail.com
Sun Jan 9 20:14:41 CET 2011


Agree to return after assert, I do not know.

However, I was convinced that using a macro (even for the same code)
was semantically better.


Le 9 janvier 2011 19:55, Rémi Denis-Courmont <remi at remlab.net> a écrit :
> Le dimanche 9 janvier 2011 20:46:28 Guillaume Poussel, vous avez écrit :
>> Hi all,
>>
>> This patch solves compilation warnings : lot of unused vars and few
>> signed/unsigned comparisons.
>> Compilation ok
>
> I don't see the point of replacing (void) casts with VLC_UNUSED which is the
> exact same thing.
>
> Also we don't return after assert(0) because some compilers and code analyzers
> *correctly* generate dead code warnings then.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



More information about the vlc-devel mailing list