[vlc-devel] Bug in filter_NewPicture()?

Juha Jeronen juha.jeronen at jyu.fi
Sun Jan 9 23:03:35 CET 2011


On 01/09/2011 11:01 PM, Laurent Aimar wrote:
>> When such pictures are released (deleted), FilterDeletePictures() (in
>> src/misc/filter_chain.c) passes the nonsense pointer to Release() in
>> src/misc/picture_pool.c when it's freeing the linked list. If my reading
>> of the source is correct, this situation may either cause a segfault,
>> trigger the assert failure I mentioned or corrupt memory silently.
>   Should be fixed (by [e2ec60cea8b4b9a0afd8b3b3f5517aa5e7657fbb] and
> [3f50c72acbf4fe8ca4f9631a3bff596cba2d3a05]).
Confirmed. Using the 3f50c72... version as a base, the soft field repeat 
supporting version of the deinterlacer no longer needs to set the 
p_nexts to NULL manually.

Thanks for fixing!


More information about the vlc-devel mailing list