[vlc-devel] Crystal HD for 1080i MPEG2 and closed captions on low-end system

[Jean-Baptiste Kempf]

Hello Devin,

On Fri, Jun 10, 2011 at 09:26:10AM -0400, Devin Heitmueller wrote :
> I actually did a bunch of patches to the EIA-608 decoder so that it
> now conforms to the spec in terms of caption placement (and fixing
> other bugs too), as well as introducing a black background under the
> text (which is what most people who actually use closed captioning
> would expect).
> 
> The patches are for vlc-1.1.5, but I suspect they would probably
> forward port without much difficulty:
> 
> http://kernellabs.com/hg/~dheitmueller/vlc-1.1.5/shortlog
>
> It would be great to see these upstreamed, but I just haven't had a
> chance to do it.

This is quite interesting, and I believe that most modules/codecs/cc.c
patches should be upstreamable without too much work.
I am not sure the corectness/logic of some of them, though...

However, the freetype module has seen some major rework and I think
Laurent is changing quite a bit how the rendering is done, so I think
the blackbox commit will not be mergeable.

The patch on v4l2 has more issues IMVHO, notably committing changes to
configure and m4, failing to use the ZVBI ifdef in all places, keeping
printf when it should be msg_Dbg, not respecting indentation size and
codestyle of the files.

Just two remarks, you are allowed to use C99 for in VLC, and you should
really check your indentation (4 spaces) for VLC code.

With my many thanks and my best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device