[vlc-devel] [PATCH 2/2] new LUA HTTP Interface Part 2 of 2

[Jean-Baptiste Kempf]

On Thu, Jun 16, 2011 at 08:52:01PM +0200, Francois Cartegnie wrote :
> You could have included the minified JQuery files: See my previous message to 
> avoid git complaining about large lines.

I disagree.

> Here's few things that will need to be fixed:

s/will need/would be nice to/

> - Not validating XHTML. A min of 23 errors on main page.
> - Units are missing on Offsets dialog
> - need to apply a vertical-align:top on tds (create stream dialog)
> - set table width to 100% (create stream)
> - 'Open' Stream Button -> 'Create' Stream (???)
> - Media Browser needs to start with a height (in case of large number of dirs)
> - Media Browser needs clickable links of the same color as other dialogs
> - Media Browser shouldn't need a double click, or if it allows multiple 
> selection, must toggle the style of selected items
> - Audio slider is not really working
> - You should not use the same color as Title Bars for SlideBars.
> - Playlist should only show filenames (display full path as tooltip)

While some points are valid, some are really nitpicking, sorry.

And a lot could be fixed/improved in later small patches.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device