[vlc-devel] [PATCH] nsis: ensure that the files are not is use before proceeding

Christophe Mutricy xtophe at chewa.net
Wed Jun 22 23:54:18 CEST 2011


On Wed, Jun 22, 11 at 16:29 +0200, Ludovic Fauvet wrote:
> A simple patch (dispite the size) for the Windows installer to ensure
> that VLC (or any of its libraries) is not in use during the
> (un)install process and thus avoid the recent user complaints about
> install failures.
>  extras/package/win32/LockedList.dll            |  Bin 0 -> 31744 bytes

Couldn't we avoid binary files in the source tarball ? Especially if
said-binary file is not package with its source.

We got a system in place to distribute binaries form of a lot of
libraries.

> +++ b/extras/package/win32/LockedList.nsh
> @@ -0,0 +1,64 @@
> +/*
> +    LockedList helper file
> +    Needs: LockedList.dll
> +
> +    LockedList plug-in is available for download here
> +    http://nsis.sourceforge.net/LockedList_plug-in

License ?

> --- a/extras/package/win32/languages/declaration.nsh
> +++ b/extras/package/win32/languages/declaration.nsh
> @@ -47,3 +47,17 @@ Var Action_OnArrivalMusicFiles
>  
> +
> +StrCpy $LockedList_Title "Programs to close"
> +StrCpy $LockedList_Text "Programs that must be closed before continuing installation"
> +StrCpy $LockedList_Heading "Close all programs from the list before continuing installation..."

After the third string the user will be very aware that some program
need closing.



-- 
Xtophe



More information about the vlc-devel mailing list