[vlc-devel] [PATCH] nsis: ensure that the files are not is use before proceeding

[Ludovic Fauvet]

Hi Christophe,

First, thank you for your comments.

On Wed, Jun 22, 2011 at 11:54 PM, Christophe Mutricy <xtophe at chewa.net> wrote:
> Couldn't we avoid binary files in the source tarball ? Especially if
> said-binary file is not package with its source.
>
> We got a system in place to distribute binaries form of a lot of
> libraries.

I thought that it was the best thing to do because:
- we already ship UAC.dll in a binary form
- the source code is meant to be built with VS so we'll need to
maintain the build script ourselves (to the extent that it allows
cross-compilation)


>> +++ b/extras/package/win32/LockedList.nsh
>> @@ -0,0 +1,64 @@
>> +/*
>> +    LockedList helper file
>> +    Needs: LockedList.dll
>> +
>> +    LockedList plug-in is available for download here
>> +    http://nsis.sourceforge.net/LockedList_plug-in
>
> License ?

This file is an include (written by me) of vlc.win32.nsi.in so it
should share the same license.
As the main nsi doesn't contains any license what should I do?

On the plugin side, its source code is provided under a zlib-like
license so we aren't required to mention it for the binary right?

>> --- a/extras/package/win32/languages/declaration.nsh
>> +++ b/extras/package/win32/languages/declaration.nsh
>> @@ -47,3 +47,17 @@ Var Action_OnArrivalMusicFiles
>>
>> +
>> +StrCpy $LockedList_Title "Programs to close"
>> +StrCpy $LockedList_Text "Programs that must be closed before continuing installation"
>> +StrCpy $LockedList_Heading "Close all programs from the list before continuing installation..."
>
> After the third string the user will be very aware that some program
> need closing.

True, I'll try to improve that in the next revision of the patch.

-- 
Ludovic Fauvet (etix)