[vlc-devel] [vlc-commits] Disable bandlimited resampler for the time being

[Rémi Denis-Courmont]

Le samedi 5 mars 2011 11:42:01 Laurent Aimar, vous avez écrit :
> On Sat, Mar 05, 2011 at 09:21:30AM +0100, Rémi Denis-Courmont wrote:
> > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Mar  5
> > 10:13:59 2011 +0200| [9c74061333bd152a1467e49ed33b889c94410da9] |
> > committer: Rémi Denis-Courmont
> > 
> > Disable bandlimited resampler for the time being
> > 
> > It is known to crash due to invalid buffer handling. On Linux, I get
> > memory accesses before the start of the audio buffer. It also crashes
> > on Windows. Until someone cares to fix it, and I think it really never
> > worked correctly, lets use the "ugly" resampler, which is not too ugly.
> 
>  Do you have a way to reproduce it? I don't have any issue with it since
> the last bug fixes done on it...
>  The only cases I had segfault was because fmt_in.audio.i_bytes_per_frame
> was incorrectly set. Could you check if it's the case for you?

Setting rate to 4 in the middle of playback crashes over half of the time 
here. Not sure if it's a bug in block_Realloc or the filter.

If you want to reproduce it under valgrind, you should really use
--no-video -I rc, then type 'rate 4'.

-- 
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis