[vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 3

[Juha Jeronen]

Hi,

Intended to post this to the list. Original message below.

 -J


Begin forwarded message:

> From: Juha Jeronen <juha.jeronen at jyu.fi>
> Date: March 8, 2011 0:26:21 GMT+02:00
> To: "Rémi Denis-Courmont" <remi at remlab.net>
> Subject: Re: [vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 3
> 
> Hi,
> 
> On Mar 7, 2011, at 21:21 , Rémi Denis-Courmont wrote:
> 
>> 	Hello,
>> 
>> Le dimanche 6 mars 2011 01:26:57 Juha Jeronen, vous avez écrit :
>>> Patch split into two as suggested. Aside from that, I updated some of
>>> the new comments and removed an unused parameter that was accidentally
>>> left in in the previous version.
>>> 
>>> Please review the attached version. If needed, I can make one more round
>>> of changes for this set. After that, I think it's time to declare this
>>> set complete :)
>> 
>> If I understood the first patch correctly, you're hacking the pitch and 
>> visible pitch to only copy every second scan line.
> 
> Yes, correct. That is the intention of field processing (in the sense the deinterlacer understands it).
> 
> The implementation is based on my interpretation of Laurent's suggestion :)
> 
> 
>> I'm not sure this belongs 
>> in the core, if it is only used internally by the deinterlacer. Or if it still 
>> goes to the core, it may need to be a little bit "cleaner"?
> 
> Maybe. I was thinking about this, too. On the other hand, it's a general plane handling operation, but on the other hand, the deinterlacer may be the only part of a video player that cares about old-fashioned concepts such as "fields".
> 
> I can do it either way. It's really up to you and Laurent as to which one you prefer :)
> 
> As for "cleaner", I'll need a bit more specific suggestions :)
> 
> 
>> In any case, I would recommend wrapping source code to 79 columns or less. I 
>> know Laurent is sometimes sloppy. But until you get commit rights, you'll have 
>> to cope with nit-picking people like myself :P
> 
> It's ok. Nitpicking is my specialty, too :P
> 
> So, 79 columns it is...
> 
> 
> -J
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110308/eafa2eb9/attachment.html>