[vlc-devel] [PATCH] KDE: Add smb to the supported protocols we can get files from without the need to fully copy them local first.

[Rémi Denis-Courmont]

Le dimanche 13 mars 2011 17:20:28 Dominique Leuenberger, vous avez écrit :
> ----- Original message -----
> 
> > Le samedi 12 mars 2011 19:06:31 Dominique Leuenberger, vous avez écrit :
> > > See https://bugs.kde.org/show_bug.cgi?id=253547 for further reference.
> > 
> > On what basis is this list build?
> > 
> > What happens if the URL requires a login/password pair?
> 
> In the past, kioexec was mainly assumed to handle it all. Then came a
> change, and apps where dumbed down to handle http and https per default,
> when %U is used.

I cannot believe KDE "dumbed" this down just for the heck of it. Afterall, if 
an application only supports files, its .desktop file won't contain %U (rather 
%f if I recall correctly). This change was probably introduced to fix 
limitations of %U. Indeed, KDE needs to know which URL protocols are actually 
supported. But then I don't understand how you came up with "http,ftp,smb". As 
far as I am concerned, this list seems to come out of nowhere as I don't see 
the rationale behind it.

But then, there's other issues. VLC will not fetch the "relevant" parameters 
from KIO. We need to get the user credentials. This is almost always required 
for SMB to work in particular, but it also can affect FTP and HTTP. And I 
won't mention other issues such as differing proxy configuration.

If your only answer is "I don't know", then as far as I am concerned your 
patch is a potential regression. In that case, it's rejected.

-- 
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis