[vlc-devel] [Patch] Karaoke Module For VLC

[Jean-Baptiste Kempf]

On Sun, Mar 20, 2011 at 03:57:46PM +0530, Pankaj yadav wrote :
> + * Copyright (C) 20011 the VideoLAN team
18k years from now? NICE

> +    float f_level;

What is this level?

> +    unsigned i_channels;

You only write in this, not use it.

> +        msg_Warn( p_filter, "bad input or output format" );
Please more explanation

> +	p_sys->f_level = var_CreateGetFloat( p_filter->p_parent, "karaoke-level" );
No tabs.

> +	p_sys->f_level = var_GetFloat( p_filter->p_parent, "karaoke-level" );
Use inherit*

> +    /* Calculate the average power level on this buffer */
> +    for( i = 0 ; i < i_samples; i++ )
Declare i here

> +    {
> +        p_out[0] = (p_in[0] - p_in[1]) * p_sys->f_level;
> +        p_out[1] = p_out[0];
> +        p_in += i_channels;
> +        p_out += i_channels;
> +    }
> +
> +    return p_in_buf;
Is that all? Ain't there something missing?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734