[vlc-devel] [Patch] Karaoke Module For VLC

[Pankaj yadav]

On Sun, Mar 20, 2011 at 5:11 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Sun, Mar 20, 2011 at 03:57:46PM +0530, Pankaj yadav wrote :
> > + * Copyright (C) 20011 the VideoLAN team
> 18k years from now? NICE
>
Rectified

>
> > +    float f_level;
>
> What is this level?
>
Removed.We should use a hard-coded value 0.7 as done by m*****r and many
others.

>
> > +    unsigned i_channels;
>
> You only write in this, not use it.
>
i have used i_channels.Should i not use it?

>
> > +        msg_Warn( p_filter, "bad input or output format" );
> Please more explanation
>
> Done

> > +     p_sys->f_level = var_CreateGetFloat( p_filter->p_parent,
> "karaoke-level" );
> No tabs.
>
Removed

>
> > +     p_sys->f_level = var_GetFloat( p_filter->p_parent, "karaoke-level"
> );
> Use inherit*
>
Removed

>
> > +    /* Calculate the average power level on this buffer */
> > +    for( i = 0 ; i < i_samples; i++ )
> Declare i here
>
> Done

> > +    {
> > +        p_out[0] = (p_in[0] - p_in[1]) * p_sys->f_level;
> > +        p_out[1] = p_out[0];
> > +        p_in += i_channels;
> > +        p_out += i_channels;
> > +    }
> > +
> > +    return p_in_buf;
> Is that all? Ain't there something missing?
>
Yes.Tested on my windows computer.

>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Pankaj Yadav
http://people.videolan.org/~pk
Open Source Enthusiast
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110320/52b00060/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-KARAOKE-module-for-VLC.patch
Type: application/octet-stream
Size: 5605 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110320/52b00060/attachment.obj>