[vlc-devel] [PATCH] Deinterlacer: authorship fixes

Juha Jeronen juha.jeronen at jyu.fi
Tue May 3 01:50:58 CEST 2011


On 05/03/2011 02:07 AM, Jean-Baptiste Kempf wrote:
> On Mon, May 02, 2011 at 08:48:49PM +0300, Juha Jeronen wrote :
>> Here's one more authorship fix to the deinterlacer based on what git
>> blame -C -C found :)
> btw, did you see many differences between -C and -C -C ?
>
> Because this is one of the theoric case where it should matter...

I didn't try with one -C, but comparing

git blame -C -C 87c209e5b4943a340dd7d0cd6e03918df664e9c9 --
modules/video_filter/deinterlace.c

and

for file in modules/video_filter/deinterlace/*.[ch] ; do echo $file ;
git blame -C -C $file ; done >blame.txt

(which takes a while) produced the difference that the second one (using
[cbad172ff6c98bacf969be6e63135fe2185a212c]) incorrectly attributed some
code to me, when it should be by Rémi (the ARM NEON merge routine). All
I did was to remove the "static" qualifier from the function when I
moved it from deinterlace.c to deinterlace/merge.c.

Curiously, both versions told me that a few people have mostly inserted
blank lines. Some code may have gotten removed over the years...


>> I think the significant contributor list is now complete.
> Applied.

Thanks!


 -J




More information about the vlc-devel mailing list