[vlc-devel] Reworking OpenSLES audio output
remi at remlab.net
Fri May 6 16:36:29 CEST 2011
On Fri, 6 May 2011 15:29:35 +0200, Hugo Beauzee-Luyssen
> New version.
> Best regards.
You've made something simple, a timed loop really complicated. There are
quite many examples how to do that, e.g. ALSA.
Similarly, next_date seems totally useless. That's quite much intricacy to
compute currentDate = mdate().
And please use saner indentation and wrap. It's really annoying to read
with 80 columns.
SLDataFormat_PCM format_pcm could really use named members for
Anyway, I still believe the PulseAudio infinite leak bug is present. If
CountAvailableBuffers returns 0, audio buffers are never freed.
More information about the vlc-devel