[vlc-devel] Reworking OpenSLES audio output

[Hugo Beauzee-Luyssen]

2011/5/6 Rémi Denis-Courmont <remi at remlab.net>:
> On Fri, 6 May 2011 15:29:35 +0200, Hugo Beauzee-Luyssen
>> New version.
>> Best regards.
>
> You've made something simple, a timed loop really complicated. There are
> quite many examples how to do that, e.g. ALSA.
>

I just try with a simple timed loop, results are quite bad.

> Similarly, next_date seems totally useless. That's quite much intricacy to
> compute currentDate = mdate().
>
Fixed.

> And please use saner indentation and wrap. It's really annoying to read
> with 80 columns.
>
Should be fixed.

> SLDataFormat_PCM format_pcm could really use named members for
> initialization.
>
Fixed

> Anyway, I still believe the PulseAudio infinite leak bug is present. If
> CountAvailableBuffers returns 0, audio buffers are never freed.
>

Indeed. Does counting the time since last buffer was enqueued, and
discarding some blocks when it's been too long seems ok to you ?

-- 
Hugo Beauzée-Luyssen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opensles.c
Type: text/x-csrc
Size: 14347 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110506/801c60be/attachment.c>