[vlc-devel] Reworking OpenSLES audio output

[Rémi Denis-Courmont]

Le vendredi 6 mai 2011 19:23:45 Hugo Beauzee-Luyssen, vous avez écrit :
> 2011/5/6 Rémi Denis-Courmont <remi at remlab.net>:
> > On Fri, 6 May 2011 15:29:35 +0200, Hugo Beauzee-Luyssen
> > 
> >> New version.
> >> Best regards.
> > 
> > You've made something simple, a timed loop really complicated. There are
> > quite many examples how to do that, e.g. ALSA.
> 
> I just try with a simple timed loop, results are quite bad.

Your code must be damn wrong if simplifying thread handling creates "quite 
bad" results.

> > Anyway, I still believe the PulseAudio infinite leak bug is present. If
> > CountAvailableBuffers returns 0, audio buffers are never freed.
> 
> Indeed. Does counting the time since last buffer was enqueued, and
> discarding some blocks when it's been too long seems ok to you ?

I'm not god. I don't know whether code you have not even written as yet is OK 
or not OK. Can't you tell whether a FIFO remains bounded??

-- 
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis