[vlc-devel] [vlc-commits] vlc-thumb: video thumbnailer for nautilus

[Rémi Denis-Courmont]

On Mon, 16 May 2011 00:02:30 +0200 (CEST), git at videolan.org (Rafaël Carré)
wrote:
> +    *in  = argv[idx++];
> +    *out = strdup(argv[idx++]);
> +    assert(*out);

assert() is for errors that should never happen, and might not be compiled
in...
Please use if(!*out) abort(); or something.


> +#if 1
> +        "--verbose=2",                      /* full log                

>    */
> +#endif

#ifndef NDEBUG
?

> +    /* mandatory to support UTF-8 filenames (provided the locale is
well
> set)*/
> +    setlocale(LC_ALL, getenv("LANG"));

Why getenv() instead of "" ?

-- 
Rémi Denis-Courmont
http://www.remlab.net/