[vlc-devel] [vlc-commits] macosx: fixed another crash after the video stopped playing

[Pierre d'Herbemont]

What's the stack trace of the crash?

On Sun, May 22, 2011 at 3:34 PM, Pierre d'Herbemont <pdherbemont at free.fr> wrote:
> On Sat, May 21, 2011 at 6:54 PM, Felix Paul Kühne <git at videolan.org> wrote:
>> vlc/vlc-1.1 | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat May 21 18:53:55 2011 +0200| [1c33e8d2aeb0ce76181799bf0d96b5fc97f6840a] | committer: Felix Paul Kühne
>>
>> macosx: fixed another crash after the video stopped playing
>>
>>> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=1c33e8d2aeb0ce76181799bf0d96b5fc97f6840a
>> ---
>>
>>  modules/gui/macosx/vout.m |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/modules/gui/macosx/vout.m b/modules/gui/macosx/vout.m
>> index 332343f..b5a33ff 100644
>> --- a/modules/gui/macosx/vout.m
>> +++ b/modules/gui/macosx/vout.m
>> @@ -666,7 +666,7 @@ int DeviceCallback( vlc_object_t *p_this, const char *psz_variable,
>>             }
>>             var_SetCoords( p_vout, "mouse-moved", x, y );
>>         }
>> -        if( [self isFullscreen] )
>> +        if( self && [self isFullscreen] )
>>             [[[[VLCMain sharedInstance] controls] fspanel] fadeIn];
>>     }
>
> [self isFullscreen] returns nil if self is nil, which will resolves as
> false. This must be something else.
>
> Pierre.
>