[vlc-devel] failure to handle ' within " " block

[Rob]

Hi Folks,

I missed Rémi's response earlier.

> This does not look right, though I don't fully grasp the existing logic.

He was responding to this patch from me:

http://mailman.videolan.org/pipermail/vlc-devel/2011-April/079984.html

can anyone shed any light?

What I have proposed does fix an real bug - but it would help if someone  
actually did understand properly what is going on in that parsing section  
to either confirm that the fix is ok, or give some pointers on how to do  
it better.

thanks,

Rob

On Sun, 01 May 2011 15:40:47 +0100, Rémi Denis-Courmont <remi at remlab.net>  
wrote:

>    Hello,
>
> On Thursday 28 April 2011, Rob wrote:
>> VLC on Windows, fails to deal properly with the ' within the " " pair in
>> this command. Instead, it treats it as closing the block, and then goes  
>> on
>> to really mangle the parameters.
>>
>> vlc.exe -I dummy "C:\Temp\Videos\Movie.mpg"
>> --sout=#transcode{vcodec=h264,venc=x264}:std{access=livehttp{seglen=10,inde
>> x="C:\Fo'lder\Movie/stream.m3u8",index-url=stream-###.ts},mux=ts{use-key-fr
>> ames},dst="C:\Fo'lder\Movie/stream-###.ts"}
>>
>>
>> This patch fixes the issue. I'm not sure if it breaks other stuff. Is  
>> this
>> the right way to go about this?
>
> This does not look right, though I don't fully grasp the existing logic.