[vlc-devel] [vlc-commits] configure.ac: fix use of *FLAGS_save and VLC_{SAVE, RESTORE}_FLAGS

Rémi Denis-Courmont remi at remlab.net
Sat Nov 19 13:02:10 CET 2011


Le samedi 19 novembre 2011 13:46:33 Rafaël Carré, vous avez écrit :
> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sat Nov 19
> 06:41:57 2011 -0500| [49125107995744edb8ca6b6fa154f69c68e28262] |
> committer: Rafaël Carré
> 
> configure.ac: fix use of *FLAGS_save and VLC_{SAVE,RESTORE}_FLAGS
> 
> You should use them like this:
>  - modify *FLAGS and LIBS globally
>  - use VLC_SAVE_FLAGS to push the variables
>  - modify the variables for the tests
>  - use VLC_RESTORE_FLAGS when you're done to pop the variables

When do you stop making huge broken changes during code freeze? And when do 
you stop bundling unrelated changes together?

This broke all -f flags.

I removed the commit.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list