[vlc-devel] [vlc-commits] configure.ac: fix use of *FLAGS_save and VLC_{SAVE, RESTORE}_FLAGS

[Rafaël Carré]

Le Sat, 19 Nov 2011 14:02:10 +0200,
"Rémi Denis-Courmont" <remi at remlab.net> a écrit :

> Le samedi 19 novembre 2011 13:46:33 Rafaël Carré, vous avez écrit :
> > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sat Nov 19
> > 06:41:57 2011 -0500| [49125107995744edb8ca6b6fa154f69c68e28262] |
> > committer: Rafaël Carré
> > 
> > configure.ac: fix use of *FLAGS_save and VLC_{SAVE,RESTORE}_FLAGS
> > 
> > You should use them like this:
> >  - modify *FLAGS and LIBS globally
> >  - use VLC_SAVE_FLAGS to push the variables
> >  - modify the variables for the tests
> >  - use VLC_RESTORE_FLAGS when you're done to pop the variables
> 
> When do you stop making huge broken changes during code freeze?

I already mentioned what was broken, this is a long due bugfix

> And when do you stop bundling unrelated changes together?

I agree it should have been separate but it was easier for me to do
them all at once.

> This broke all -f flags.

How so?

I have -fvisibility=hidden in my CFLAGS here (as expected), buildbot is
happy.

Explain what's "broken".


> I removed the commit.

thanks for noticing

-- 
Rafaël Carré