[vlc-devel] [Patches] Dash: mostly cosmetics

[Hugo Beauzée-Luyssen]

On Fri, Nov 25, 2011 at 11:53 AM, Hugo Beauzée-Luyssen
<beauze.h at gmail.com> wrote:
> 2011/11/24 Rémi Denis-Courmont <remi at remlab.net>:
>> 0011: I don't see the point. The code becomes harder to read. I think we can
>> trust the register allocators from compilers nowadays.
>>
>> 0012: OK but does not apply without previous patches.
>>
>> 0013, 0014, 0015, 0016: merged.
>>
>> 0017: cannot comment.
>>
>
> I have to agree on patch 11.
> About patch 10, I have a few reason to get rid of the exceptions :
> - On some platforms, exceptions are deactivated
> - They are slower than a return value to indicate an error. And in
> this case, the exception or the return value doesn't change anything
> to the code itself.
> - Exceptions should (at least I think) be user for something that
> really is exceptionnal. The end of the file is something that is
> likely to happen
>
> And as a personnal point of view, I find the code easier to read once
> exceptions are removed, but that's my tastes :)
>
> Regards,
>

Here are some rebased versions, plus 3 extras :
- 2 memory leaks fixed
- 1 cosmetics

I'll let you decide about "Removing EOFException"

Regards,

-- 
Hugo Beauzée-Luyssen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-dash-MPDManager-Fixing-memory-leak.patch
Type: text/x-patch
Size: 884 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-dash-Removing-EOFException.patch
Type: application/octet-stream
Size: 12564 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dash-DOMparser-Replacing-an-init-method-by-an-init-l.patch
Type: application/octet-stream
Size: 2051 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dash-Parser-Standard-5.4.4.1-specifies-there-can-be-.patch
Type: application/octet-stream
Size: 1792 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dash-DOMParser-FIxing-memory-leak.patch
Type: application/octet-stream
Size: 873 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dash-RateBasedAdaptationLogic-cosmetics.patch
Type: text/x-patch
Size: 2143 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111125/26506f5d/attachment-0001.bin>