[vlc-devel] [vlc-commits] configure.ac: remove redundant comments
jb at videolan.org
Tue Nov 29 09:35:18 CET 2011
On Tue, Nov 29, 2011 at 03:33:31AM -0500, Rafaël Carré wrote :
> Le Tue, 29 Nov 2011 09:29:41 +0100,
> Jean-Baptiste Kempf <jb at videolan.org> a écrit :
> > On Tue, Nov 29, 2011 at 07:32:04AM +0100, Rémi Denis-Courmont wrote :
> > > On Mon, 28 Nov 2011 16:22:42 -0500, Rafaël Carré <funman at videolan.org>
> > > wrote:
> > > > dnl
> > > > dnl mpc demux plugin
> > > > dnl
> > > > AC_ARG_ENABLE(mpc,
> > > >
> > > > => the comments give no information at all
> > >
> > > It *does*. Besides, it gives makes separation between parts of the code
> > > much easier to spot, especially with syntax highlighting.
> > The configure.ac is still too long, IMVHO and sometimes the comments are
> > longer than the actual code.
> > However, it does help readability and also helps to know that libsidsdq is
> > the package required for $module.
> Not when $module requires lib$module IMVHO , that's why I wrote
> 'redundant' in the log
I would argue that it is still easier to skim through the file with
those. Maybe they could be made shorter.
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the vlc-devel