[vlc-devel] [vlc-commits] configure.ac: remove redundant comments
funman at videolan.org
Tue Nov 29 09:40:42 CET 2011
Le Tue, 29 Nov 2011 09:35:18 +0100,
Jean-Baptiste Kempf <jb at videolan.org> a écrit :
> On Tue, Nov 29, 2011 at 03:33:31AM -0500, Rafaël Carré wrote :
> > Le Tue, 29 Nov 2011 09:29:41 +0100,
> > Jean-Baptiste Kempf <jb at videolan.org> a écrit :
> > > On Tue, Nov 29, 2011 at 07:32:04AM +0100, Rémi Denis-Courmont wrote :
> > > > On Mon, 28 Nov 2011 16:22:42 -0500, Rafaël Carré <funman at videolan.org>
> > > > wrote:
> > > > > dnl
> > > > > dnl mpc demux plugin
> > > > > dnl
> > > > > AC_ARG_ENABLE(mpc,
> > > > >
> > > > > => the comments give no information at all
> > > >
> > > > It *does*. Besides, it gives makes separation between parts of the code
> > > > much easier to spot, especially with syntax highlighting.
> > >
> > > The configure.ac is still too long, IMVHO and sometimes the comments are
> > > longer than the actual code.
> > > However, it does help readability and also helps to know that libsidsdq is
> > > the package required for $module.
> > Not when $module requires lib$module IMVHO , that's why I wrote
> > 'redundant' in the log
> I would argue that it is still easier to skim through the file with
> those. Maybe they could be made shorter.
Possible, this was a preparation for a lot of other changes I had in
mind for this file to make it more readable and consistent.
I will wait a few days at least before considering if i want to make
these changes or not though and presence of comments doesn't prevent
More information about the vlc-devel