[vlc-devel] [PATCH 0/2] Add avio url output support (for rtmp)

[Rémi Denis-Courmont]

Le lundi 3 octobre 2011 21:36:46 keary.griffin at unwiredappeal.com, vous avez 
écrit :
> 2)  The second attempts to allow more than one concurrent user of the
> avio module, by using thread local storage.  Previously since avio only
> allowed a single callback to be specified without parameters, it was
> impossible to tell which "stream" it was checking on.  I've tested this and
> it seems to work, but someone with a better understanding of libavformat
> and/or VLC tls may want to take a peek.

The core looks correct though I would use an unsigned reference counter.

But it would be a lot better to get libavio fixed. Callbacks without an opaque 
data pointer are insane. In fact, I guess TLS could still fail if input-slave 
is in use; it looks to me like VLC runs all inputs in the same thread.
Also, what if any libavio back-end becomes multi-thread?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis