[vlc-devel] [PATCH 0/2] Add avio url output support (for rtmp)

Keary Griffin keary.griffin at unwiredappeal.com
Mon Oct 3 21:32:52 CEST 2011


On 10/3/2011 2:55 PM, Rémi Denis-Courmont wrote:
> But it would be a lot better to get libavio fixed. Callbacks without an opaque
> data pointer are insane.
Agreed.
> In fact, I guess TLS could still fail if input-slave
> is in use; it looks to me like VLC runs all inputs in the same thread.
I don't think this should be an issue since the avio module should be 
calling PrepareAvioCall with the correct (currently active) vlc access 
object before entering any libavio calls, thus setting the thread local 
storage for that thread to the right value (and that same thread won't 
have a chance to make another avio call until that call returns...)
> Also, what if any libavio back-end becomes multi-thread?
This would indeed be an issue, but only if it makes the callback from a 
different thread, which I would hope would be a big enough "change" that 
they would think twice before making a change like that(?)

Another option is to just not use the callback at all (so there would be 
no way to cancel an avio call), but I'm not sure what the repercussions 
would be.

Thanks
Keary



More information about the vlc-devel mailing list