[vlc-devel] [PATCH] Preserve offsets set by source decoder
stephan.krempel at gmx.de
Thu Oct 6 17:04:10 CEST 2011
> I think you should move it inside (without the test):
> if( !fmt.i_visible_width || !fmt.i_visible_height )
> if( p_dec->fmt_in.video.i_visible_width &&
> p_dec->fmt_in.video.i_visible_height )
> otherwise you will override what a decoder set (ex: theora with ogg).
You are right.
But now I wonder whether it isn't the responsibility of the decoder to
care about any format setting done by the demuxer. Perhaps I am at
the wrong place at all to fix that issue (#4600).
What is the reason for the check for the visible dimensions? Why can't
we rely on them to be already set correctly?
More information about the vlc-devel