[vlc-devel] [PATCH] Preserve offsets set by source decoder

[Stephan Krempel]

On Thu, 6 Oct 2011 17:04:10 +0200
Stephan Krempel <stephan.krempel at gmx.de> wrote:
> 
> > I think you should move it inside (without the test):
> > if( !fmt.i_visible_width || !fmt.i_visible_height )
> > {
> >     if( p_dec->fmt_in.video.i_visible_width &&
> > 	p_dec->fmt_in.video.i_visible_height )
> >     {
> >         <here>
> >     }
> > }
> > 
> > otherwise you will override what a decoder set (ex: theora with
> > ogg).
> > 
> 
> You are right.
> 
> But now I wonder whether it isn't the responsibility of the decoder to
> care about any format setting done by the demuxer. Perhaps I am at
> the wrong place at all to fix that issue (#4600).
> What is the reason for the check for the visible dimensions? Why can't
> we rely on them to be already set correctly?
> 

For now I produced a new patch (attached) doing it as Laurent said,
since I'd really like #4600 to be fixed.
Nevertheless, I am still interested in an answer to my questions above.

Regards,
Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Preserve-offsets-set-by-demuxer.patch
Type: text/x-patch
Size: 1025 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111007/f045eb0a/attachment.bin>