[vlc-devel] [PATCH 38/41] Add OS/2 support to freetype module

[Jean-Baptiste Kempf]

On Mon, Oct 10, 2011 at 08:44:17PM +0900, KO Myung-Hun wrote :
> +#elif defined( __OS2__ )
> +# define DEFAULT_FONT_FILE "/psfonts/tnrwt_k.ttf"
> +# define DEFAULT_FAMILY "Times New Roman WT K"

Ok.

> +#ifdef __OS2__
> +# define UCHAR uint16_t
Why can't it be uint32_t?

> +# define FREETYPE_TO_UCS    "UCS-2LE"
> +#else
> +# define UCHAR uint32_t
> +# if defined(WORDS_BIGENDIAN)
> +#  define FREETYPE_TO_UCS   "UCS-4BE"
> +# else
> +#  define FREETYPE_TO_UCS   "UCS-4LE"
> +# endif
> +#endif

> +#ifdef __OS2__
> +    FcInit();
> +#endif

Why do you need FcInit, when other OS don't?

> -        i_string_length = i_string_bytes / 4;
> +        i_string_length = i_string_bytes / sizeof( UCHAR );
sizeof( *psz_tmp ); maybe

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device