[vlc-devel] [PATCH 38/41] Add OS/2 support to freetype module

[KO Myung-Hun]

Jean-Baptiste Kempf wrote:
> On Mon, Oct 10, 2011 at 08:44:17PM +0900, KO Myung-Hun wrote :
>> +#elif defined( __OS2__ )
>> +# define DEFAULT_FONT_FILE "/psfonts/tnrwt_k.ttf"
>> +# define DEFAULT_FAMILY "Times New Roman WT K"
> 
> Ok.
> 
>> +#ifdef __OS2__
>> +# define UCHAR uint16_t
> Why can't it be uint32_t?
> 

As you see below, OS/2 uses UCS-2. And its size is 2 bytes.

>> +# define FREETYPE_TO_UCS    "UCS-2LE"
>> +#else
>> +# define UCHAR uint32_t
>> +# if defined(WORDS_BIGENDIAN)
>> +#  define FREETYPE_TO_UCS   "UCS-4BE"
>> +# else
>> +#  define FREETYPE_TO_UCS   "UCS-4LE"
>> +# endif
>> +#endif
> 
>> +#ifdef __OS2__
>> +    FcInit();
>> +#endif
> 
> Why do you need FcInit, when other OS don't?
> 

FontConfig port for OS/2 require this. It is not a direct port of
FontConfig. It has been written to provide equivalent features.

>> -        i_string_length = i_string_bytes / 4;
>> +        i_string_length = i_string_bytes / sizeof( UCHAR );
> sizeof( *psz_tmp ); maybe
> 

Ok.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0038-Add-OS-2-support-to-freetype-module.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111011/6d8754f0/attachment.ksh>