[vlc-devel] [PATCH 19/41] Implement thread support for OS/2

[Rémi Denis-Courmont]

On Tue, 18 Oct 2011 21:27:02 +0900, KO Myung-Hun <komh78 at gmail.com> wrote:
> Rémi Denis-Courmont wrote:
>> Comments inline...
>> 
>> Le lundi 10 octobre 2011 14:43:58 KO Myung-Hun, vous avez écrit :
> ...
>>> @@ -149,6 +152,11 @@
>>>   #include <sys/syslimits.h>
>>>  #endif
>>>
>>> +#ifdef __OS2__
>>> +#   include <unistd.h>
>>> +#   include <time.h>
>>> +#endif
>>> +
>> 
>> Those two headers should not be needed in <vlc_common.h>. Normally,
>> files that
>> dependent on them already include them explicitly.
>> 
> 
> You missed the patch for langfromtelx.c.
> 
> I modified the patch slightly.
> 
> This is required for off_t of vlc_sout.h.

Err? ssize_t and off_t are in <sys/types.h> not in <unistd.h>.

I don't like to promiscuously include headers from other headers. It
always ends up a mess when reorganizing header files.

-- 
Rémi Denis-Courmont
http://www.remlab.net/