[vlc-devel] [PATCH 19/41] Implement thread support for OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> On Tue, 18 Oct 2011 21:27:02 +0900, KO Myung-Hun <komh78 at gmail.com> wrote:
>> Rémi Denis-Courmont wrote:
>>> Comments inline...
>>>
>>> Le lundi 10 octobre 2011 14:43:58 KO Myung-Hun, vous avez écrit :
>> ...
>>>> @@ -149,6 +152,11 @@
>>>>   #include <sys/syslimits.h>
>>>>  #endif
>>>>
>>>> +#ifdef __OS2__
>>>> +#   include <unistd.h>
>>>> +#   include <time.h>
>>>> +#endif
>>>> +
>>>
>>> Those two headers should not be needed in <vlc_common.h>. Normally,
>>> files that
>>> dependent on them already include them explicitly.
>>>
>>
>> You missed the patch for langfromtelx.c.
>>
>> I modified the patch slightly.
>>
>> This is required for off_t of vlc_sout.h.
> 
> Err? ssize_t and off_t are in <sys/types.h> not in <unistd.h>.
> 

On OS/2, they are defined in unistd.h as well.

> I don't like to promiscuously include headers from other headers. It
> always ends up a mess when reorganizing header files.
> 

I agree.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0009-Include-missing-unistd.h-for-OS-2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111019/798d7e1c/attachment.ksh>