[vlc-devel] [PATCH] opengl: enables shaders for macos opengl.

[Laurent Aimar]

On Tue, Sep 13, 2011 at 09:52:56PM +0200, Sebastien Zwickert wrote:
> 
> On Sep 13, 2011, at 9:41 PM, Laurent Aimar wrote:
> 
> > On Tue, Sep 13, 2011 at 09:24:19PM +0200, Sebastien Zwickert wrote:
> >> 
> >> On Sep 13, 2011, at 8:52 PM, Laurent Aimar wrote:
> >> 
> >>> On Tue, Sep 13, 2011 at 08:50:53PM +0200, Laurent Aimar wrote:
> >>>> Couldn't we simply remove all the specific macosx part?
> >>>> Is there
> >>>> a performance loss?
> >>> 
> >>> I am asking because:
> >>> - it would be simpler to maintain
> >>> - I think it would also be faster as it would avoid a full frame
> >>> copy BUT it needs to be tested to be sure.
> >> 
> >> It's possible to share almost all the same code and to remove a lot of specific macosx part. I will provide a patch in this way to test performance.
> > That would be great, thanks. Do you think you could try to test the
> > performances? 
> 
> I could try but I'm not sure to have tools to test performances loss or gain. There're some graphic tools delivered with the developer package on macosx but i never used these. I need to take a look at these tools to see if there's something to test performances between different versions.
 I am not sure what the "graphic tools" will mesure. The GPU usage may be
higher (but that is expected as we are using it more), but I am hoping that
the CPU usage will be lower.
 Now, if simply playing HD video does not seems to change your CPU usage
(using top, time or any other tools), then we can consider the loss/gain
negligeable IMHO and use the simpler code.

-- 
fenrir